Send link as href in embedded object#13
Merged
SphtKr merged 1 commit intoJSONAPIdotNET:masterfrom Jan 21, 2015
Merged
Conversation
Collaborator
|
Crap, you're right...I wonder if the spec changed since I implemented that, but I see what you mean about why it needs to be discernable from an Id. This will break previous behavior, so it will probably be helpful to go to 0.3.0 when this is put into a release. |
Collaborator
|
Got #8 committed, so you should be able to rebase now. |
cac3019 to
ac5c469
Compare
Collaborator
Author
|
All ready to go! |
SphtKr
added a commit
that referenced
this pull request
Jan 21, 2015
Send link as href in embedded object
Collaborator
|
Ugh...for future reference, we should watch this issue, which would reverse this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the spec, sending a link should look like this:
The formatter is currently sending:
There is no way for the client to tell that that is a link and not an ID. This PR changes the handling for
[SerializeAs(SerializeAsOptions.Link)]to put the link on anhrefkey in an embedded object.I needed the json minifier helper from #8, so I included it here as a separate commit. I may need to rebase one of these PRs when you merge the other.